Skip to content

Fix failed merge after #3815 #3876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix failed merge after #3815 #3876

wants to merge 1 commit into from

Conversation

guilliamxavier
Copy link
Contributor

See #3815 (comment) (and following)

@nikic @guilliamxavier
Fix tests bareword fallback with error suppression
7252a26 
Re-merge commit a369326 into PHP-7.4
(cherry picked from commit aad3987)
(cherry picked from commit 76f8a90)
@guilliamxavier guilliamxavier mentioned this pull request Feb 23, 2019
Closed
guilliamxavier referenced this pull request Feb 23, 2019
@nikic
Remove bareword fallback for constants
aad3987 
Access to undefined constants will now always result in an Error
exception being thrown.

This required quite a few test changes, because there were many
buggy tests that unintentionally used bareword fallback in combination
with error suppression.
@nikic
Copy link
Member

nikic commented Feb 25, 2019

Applied as b4cbf6f, thanks!

@nikic nikic closed this Feb 25, 2019
@guilliamxavier guilliamxavier deleted the fix-tests-bareword-fallback-error-suppression-7.4 branch February 25, 2019 17:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikic nikic nikic approved these changes

Assignees
No one assigned
Labels
Category: Tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@guilliamxavier @nikic @petk